Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: specify method ID for getters #922

Merged
merged 7 commits into from
Oct 7, 2024
Merged

feat: specify method ID for getters #922

merged 7 commits into from
Oct 7, 2024

Conversation

anton-trunov
Copy link
Member

@anton-trunov anton-trunov commented Oct 7, 2024 •
edited
Loading

Issue

Closes #876.

Related issues

After something like ton-org/ton-core#46 is merged and released, we can remove as any from the TypeScript wrappers generator

Checklist

  • I have updated CHANGELOG.md
  • I have documented my contribution in docs/ and made the build locally
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov anton-trunov added this to the v1.6.0 milestone Oct 7, 2024
@anton-trunov anton-trunov self-assigned this Oct 7, 2024
@anton-trunov anton-trunov requested a review from a team as a code owner October 7, 2024 13:30
@anton-trunov
Copy link
Member Author

@novusnota I'd need your suggestion on how to make available since Tact v1.6 work here.

@novusnota
Copy link
Member

novusnota commented Oct 7, 2024 •
edited
Loading

@anton-trunov right away I see couple of options, each using Badge component:

  1. For the particular description of the new feature, we add a sub-heading and right after it we place:
### Resolving collisions of method IDs

<Badge text="Available since Tact 1.6" variant="tip" size="medium" /><p/>

Sometimes this can get you the same method ID...(and the following, with a slight re-write of the beginning)
  1. Alternatively, we place a full stop in this sentence: "If this happens, you can either rename some of the contract's getters or specify the getter's method ID manually.". Then, we place the badge as before, and continue with the example. Code for example can also start with // runnable since Tact 1.6

@anton-trunov anton-trunov merged commit 247b255 into main Oct 7, 2024
18 checks passed
@anton-trunov anton-trunov deleted the method-id branch October 7, 2024 16:35
This was referenced Oct 8, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeshecdom jeshecdom jeshecdom approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Allow manually specifying method_id for getters
3 participants
@anton-trunov @novusnota @jeshecdom